PR: Improve performance of SpragueInterpolator #1268
Conversation
|
Two tests are failing =========================== short test summary info ============================
FAILED colour/colorimetry/generation.py::colour.colorimetry.generation.sd_gaussian
FAILED colour/colorimetry/generation.py::colour.colorimetry.generation.sd_gaussian_fwhm
===== 2 failed, 3464 passed, 11 skipped, 190 warnings in 185.65s (0:03:05) =====However, my local environment passes these... :/ sneaky. Will investigate. |
|
@KelSolaar the failing tests are doctest(s) in |
KelSolaar
changed the title
|
Hey @tjdcs, Thanks a lot! Yeah ellipsis would be absolutely fine here. Cheers, Thomas |
colour/algebra/interpolation.py
Outdated
| # Fancy vector code here... use underlying numpy structures to accelerate | ||
| # parts of the linear algebra. | ||
|
|
||
| y = r[i] + np.einsum( | ||
| "ab,ab->b", a.reshape(5, -1), X ** np.arange(1, 6).reshape(-1, 1) | ||
| ) |
There was a problem hiding this comment.
With the desire to move toward data-array API compliance and because Einstein Sum is not planned to be supported, we should try to rewrite this using lower level APIs: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html
There was a problem hiding this comment.
I removed all usages of np.einsum in develop.
tjdcs
force-pushed
the
performance/interpolation
branch
from
ea330ed
to
6500280
Compare
for more information, see https://pre-commit.ci
tjdcs
force-pushed
the
performance/interpolation
branch
from
9dfdc08
to
94f34ae
Compare
|
@KelSolaar looks like these are all passing now. Should be g2g when the last few tasks finish. |
SpragueInterpolatoris the default interpolator forSpectralDistributionmaking it a highly frequented code path. This PR greatly improves the performance of interpolation by using vectorized code and numpy.Other interpolators could be similarly sped up but they are lower priority.