Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Implement "Chromatic Adaptation Models" support. #132

Merged
merged 24 commits into from
Oct 25, 2014
Merged

PR: Implement "Chromatic Adaptation Models" support. #132

merged 24 commits into from
Oct 25, 2014

Conversation

KelSolaar
Copy link
Member

References #120.

This was referenced Sep 13, 2014
Closed
Closed
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) when pulling dd675b6 on feature/chromatic_adaptation_models into 5d72b41 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 46a33b5 on feature/chromatic_adaptation_models into 5d72b41 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling eeaf89c on feature/chromatic_adaptation_models into 5d72b41 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling eeaf89c on feature/chromatic_adaptation_models into 5d72b41 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) when pulling c0f1267 on feature/chromatic_adaptation_models into 5d72b41 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) when pulling 25a587a on feature/chromatic_adaptation_models into 5d72b41 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) when pulling bc1e081 on feature/chromatic_adaptation_models into 5d72b41 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) when pulling 7f7a28f on feature/chromatic_adaptation_models into 5d72b41 on develop.

@MichaelMauderer
Copy link
Member

Looks fine as far as I can tell, but I noticed that the naming convention does not yet follow issue #151. (e.g., chromatic_adaptation_vonkries)

@KelSolaar
Copy link
Member Author

Yes, I will do the naming convention pass when we have merged everything together, it started to be complicated to track all the changes across all branches so I postponed that for later.

@KelSolaar @MichaelMauderer
Implement support for "CMCCAT2000" chromatic adaptation model.
ab1ed63 
References #120.
@KelSolaar @MichaelMauderer
Add "optional" descriptor to parameters docstrings.
60af816
@KelSolaar @MichaelMauderer
Use consistent data in "colour.adaptation.tests.tests_cmcat2000" modu…
b0f1530 
…le unit tests.
@KelSolaar @MichaelMauderer
Implement skeleton for "CIE 1994" chromatic adaptation model.
340b759
@KelSolaar @MichaelMauderer
Implement "CIE 1994" chromatic adaptation model.
0722d73 
References #120.
@KelSolaar @MichaelMauderer
Implement skeleton for "Fairchild (1990)" chromatic adaptation model.
a788d15
@KelSolaar @MichaelMauderer
Implement support for "Fairchild (1990)" chromatic adaptation model.
f1872ac 
References #120.
@KelSolaar @MichaelMauderer
Add convenient "colour.adaptation.chromatic_adaptation_CMCCAT2000" de…
bb181c5 
…finition.
@KelSolaar @MichaelMauderer
Refactor "colour.adaptation.cat" module.
855fbd0
@KelSolaar @MichaelMauderer
Add "Chromatic Adaptation Models" examples.
ca7afc2
@KelSolaar @MichaelMauderer
Fix broken unit tests in "colour.adaptation.tests.tests_cmccat2000" m…
cac5a4e 
…odule.
@KelSolaar @MichaelMauderer
Add "Breneman" experimental result data for chromatic adaptation.
aff8d93 
Closes #134.
@KelSolaar @MichaelMauderer
Add support for corresponding chromaticities prediction computations.
2dcb733
@KelSolaar @MichaelMauderer
Add examples for "colour.corresponding.prediction" module.
252dcf8
@KelSolaar @MichaelMauderer
Add "Corresponding Chromaticities Prediction" figures.
46a9193 
Closes #137.
@MichaelMauderer MichaelMauderer force-pushed the feature/chromatic_adaptation_models branch from 213eecd to 62ef3e0 Compare October 25, 2014 17:39
MichaelMauderer added a commit that referenced this pull request Oct 25, 2014
@MichaelMauderer
Merge pull request #132 from colour-science/feature/chromatic_adaptat…
584d38d 
…ion_models

PR: Implement "Chromatic Adaptation Models" support.
@MichaelMauderer MichaelMauderer merged commit 584d38d into develop Oct 25, 2014
@MichaelMauderer MichaelMauderer deleted the feature/chromatic_adaptation_models branch October 25, 2014 17:52
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) when pulling 290c2d6 on feature/chromatic_adaptation_models into a3d85a6 on develop.

@KelSolaar KelSolaar added this to the v0.3.3 milestone Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@KelSolaar @coveralls @MichaelMauderer