Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PhantomJS to 2.1.1 #66

Merged
merged 1 commit into from
Jan 28, 2016
Merged

Update PhantomJS to 2.1.1 #66

merged 1 commit into from
Jan 28, 2016

Conversation

sashee
Copy link
Contributor

@sashee sashee commented Jan 25, 2016

The phantom.args got removed, had to use system.args (http://phantomjs.org/api/phantom/property/args.html)

And the windows exe is now inside bin.

@sashee sashee mentioned this pull request Jan 25, 2016
Closed
@sashee
Copy link
Contributor Author

sashee commented Jan 25, 2016

Bitbucket often return rate limit errors, and they break the tests. Rerun them a few times if you get errors.

@BrianHawley BrianHawley mentioned this pull request Jan 26, 2016
Closed
@colszowka
Copy link
Owner

On all rubies except 2.0 I'm getting an error while installing the multi_json gem it seems :( The 2.0 build passed on travis after hitting rebuild

NoMethodError: undefined method `spec' for nil:NilClass
Installing json 1.8.3
An error occurred while installing phantomjs (2.1.1.0), and Bundler cannot
continue.
Make sure that `gem install phantomjs -v '2.1.1.0'` succeeds before bundling.
The command "eval bundle install --jobs=3 --retry=3" failed. Retrying, 2 of 3.

@colszowka
Copy link
Owner

That issue seems to have been fixed by #67, merging. Thank you!

colszowka added a commit that referenced this pull request Jan 28, 2016
@colszowka
Merge pull request #66 from sashee/master
84e28e6 
Update PhantomJS to 2.1.1
@colszowka colszowka merged commit 84e28e6 into colszowka:master Jan 28, 2016
durandom pushed a commit to durandom/manageiq that referenced this pull request Feb 29, 2016
Merge branch '55-phantom1x' into '5.5.z'
1c99efa 
Force phantomjs <2

1.9.8.0 is the last 1.x version, the next is 2.1.1

(dependend upon implicitly by jasmine-rails)

Seems to fix the `test:javascript` hangs, which would mean they were caused by the phantomjs 1.9.8 -> 2.1.1 upgrade 12 days ago.. (colszowka/phantomjs-gem#66)

See merge request !774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sashee @colszowka