Upgrade to Capybara 2

[infertux]

Hi,

Those cukes failing with Capybara 2 were bothering me. The main issue was that Capybara 2 doesn't look for text in hidden DOM elements anymore (which makes sense!) so we now need to use a JS-enabled driver. I went ahead and picked capybara-webkit. Poltergeist is cool too because truly headless thanks to PhantomJS but it requires Ruby 1.9.2+. You might want to use another one. I also tweaked a bit the fake Rack app to serve other resources such as JS files.

There's probably a minor overhead (although I can't see any difference locally) running cukes with JS but I thought it'd be more relevant for integration tests.

Also references 239db29.

[colszowka]

Merged, thanks :) I will probably go and switch it to poltergeist as in the past I've had less headaches with that and it recently got capybara 2 support. Especially on plain debian I bumped into loads of trouble trying to get qt compiled as it is not supplied with the packages.

[infertux]

The issue with Poltergeist is that it won't even install on rubies < 1.9.2: https://travis-ci.org/colszowka/simplecov/jobs/5738890. You could still wrap references to it within if RUBY_VERSION >= '1.9.2' but that's a bit messy IMHO.

[colszowka]

Hmmmm, crap. I didn't realize it would outright fail to install for non-1.9 ruby :( And that after I finally made the build pass reliably on travis earlier today 😿

What is most annoying is that I'm not even interested in using poltergeist on Ruby <1.9, but it needs to get installed for those as well when listed in the simplecov gemspec, and that fails due to poltergeists gemspec

I think the best way would probably be to shuffle poltergeist over to the actual Gemfile. Since it's a dev dependency only anyway that should be good enough. There, some kind of platform depending switch could ensure it's not installed on pre 1.9.

[colszowka]

Ok, made the cuke suite and it's dependencies available on 1.9+ only. Travis build for MRIs and rbx/jruby 1.8 passed, waiting for JRuby 1.9, but it seems that this particular problem with installing poltergeist is resolved now :)

[infertux]

Sorry for the delay, that sounds good.

I see you like the '1.9+'.respond_to? :encoding trick, it looks a bit misleading to me but I'm just being fussy ;). Is there any reason not to prefer RUBY_VERSION > '1.9'?

Btw, just curious: do you plan to drop Ruby 1.8 support in a future big release? It'll EOL in June and this would save troubles like this one, MultiJSON, etc. - especially since there's no coverage report available on 1.8 and this is only to make sure SimpleCov doesn't break anything.

Thanks and kudos for the steady green build :)

[colszowka]

Actually there used to be some reason not to use RUBY_VERSION in the past. It may be that this constant was not available in Ruby 1.8.6 or something like that, but yeah, probably nowadays just using that should be much easier. Another example of how we should always question our habits :)

Yeah, I think I'll be dropping 1.8 support soon. I'll be wrapping a 0.8.0 release over easter, I might modify the current warning when using a 1.8 implementation to warn that simplecov will be dropping support for that in the next release, be it 0.9 or 1.0.