add a group for Active Jobs classes to default Rails profile #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, makes sense to have this! Since with the existing frameworks like sidekiq and resque, the convention is to go with "app/workers", could you please add this dir as well? You can pass in an array of paths, so |
|
Hi @colszowka, thanks for the feedback. I updated the pull request based on your suggestion and rebased against master so that it will merge cleanly. |
colszowka
added a commit
that referenced
this pull request
Jan 27, 2016
add a group for Active Jobs classes to default Rails profile
|
Thank you @stve ! |
colszowka
added a commit
that referenced
this pull request
Jan 27, 2016
craiglittle
pushed a commit
to craiglittle/simplecov
that referenced
this pull request
Feb 13, 2016
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Feb 17, 2016
## Enhancements ## Bugfixes 0.11.2 2016-02-03 ([changes](simplecov-ruby/simplecov@v0.11.1...v0.11.2)) ================= ## Enhancements * Do not globally pollute Array and Hash with `merge_resultset` utility methods. See [#449](simplecov-ruby/simplecov#449) (thanks @amatsuda) * Do not `mkdir_p` the `coverage_path` on every access of the method (See [#453](simplecov-ruby/simplecov#453) (thanks @paddor) * Fixes a Ruby warning related to the `track_files` configuration. See [#447](simplecov-ruby/simplecov#447) (thanks @craiglittle) * Add a group for background jobs to default Rails profile. See [#442](simplecov-ruby/simplecov#442) (thanks @stve) ## Bugfixes * Fix root_filter evaluates SimpleCov.root before initialization. See [#437](simplecov-ruby/simplecov#437) (thanks @tmtm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Active Job in a Rails project for the first time and my job classes are currently "Ungrouped". Since
app/jobsis the default location for these classes, I think it's worth adding this to the Rails profile.Are there tests for this? I couldn't find any but if I've missed them, please point them out and I'll add a test as well. Thanks