Silence @track_files_glob ivar warning
#447
Conversation
|
The build failed due to #448 apparently, we'll have to get that one out of the door first. We've been dealing with those pesky ruby warnings basically since the beginning of the project, thanks for taking the time to take this one out! In order to keep things consistent, could you please change the implementation to what we're doing for all the other instance vars in the configuration class? See for example https://github.com/craiglittle/simplecov/blob/fix-ivar-warning/lib/simplecov/configuration.rb#L36-L37, basically we return if the var is defined and truthy, otherwise do the assignment. I would prefer not to introduce another pattern for dealing with these things here. It's arguable though whether your solution isn't nicer/cleaner - if you prefer I'd also be good if we changed the existing methods to use your style of pre-initializing on extend. |
|
Sure, I'll change the other methods to pre-initialize the instance variables in the |
craiglittle
force-pushed
the
fix-ivar-warning
branch
from
cc751a7
to
ae3507b
Compare
|
Okay, I decided to go the other direction and switch the Once we get the RuboCop PR squared away, I'll rebase this onto latest master. |
craiglittle
force-pushed
the
fix-ivar-warning
branch
from
ae3507b
to
8c1730d
Compare
|
Perfect, thank you! |
|
apologies for the bad intel, I didn't realise we had prior art! |
|
It's not the best style, but this build failed solely because of Rubycop, which was fixed in #451, so I'm merging this to avoid having to make another roundtrip with @craiglittle for rebasing this against master |
Silence `@track_files_glob` ivar warning
|
Do you think a release will be cut soon? It'd be swell to get this warning out of my build. :) |
|
@craiglittle Yes, it's out in 0.11.2 right now |
|
Awesome, much appreciated! 😄 |
Fixes simplecov-ruby#462. The implementation of `track_files` was refactored recently to suppress a warning in the underlying instance variable had not been initialized. This had the effect of changing the behavior when trying to nullify the default configuration of tracked files in some cases through the use of nil. With this change, a declaration of `track_files nil` will once again clear out any previous configuration and essentially disable the feature. Reference: * simplecov-ruby#447 * simplecov-ruby#462
Fixes simplecov-ruby#462. The implementation of `track_files` was refactored recently to suppress a warning in the underlying instance variable had not been initialized. This had the effect of changing the behavior when trying to nullify the default configuration of tracked files in some cases through the use of nil. With this change, a declaration of `track_files nil` will once again clear out any previous configuration and essentially disable the feature. Reference: * simplecov-ruby#447 * simplecov-ruby#462
Fixes simplecov-ruby#462. The implementation of `track_files` was refactored recently to suppress a warning in the underlying instance variable had not been initialized. This had the effect of changing the behavior when trying to nullify the default configuration of tracked files in some cases through the use of nil. With this change, a declaration of `track_files nil` will once again clear out any previous configuration and essentially disable the feature. Reference: * simplecov-ruby#447 * simplecov-ruby#462
Fixes simplecov-ruby#462. The implementation of `track_files` was refactored recently to suppress a warning in the underlying instance variable had not been initialized. This had the effect of changing the behavior when trying to nullify the default configuration of tracked files in some cases through the use of nil. With this change, a declaration of `track_files nil` will once again clear out any previous configuration and essentially disable the feature. Reference: * simplecov-ruby#447 * simplecov-ruby#462
## Enhancements ## Bugfixes 0.11.2 2016-02-03 ([changes](simplecov-ruby/simplecov@v0.11.1...v0.11.2)) ================= ## Enhancements * Do not globally pollute Array and Hash with `merge_resultset` utility methods. See [#449](simplecov-ruby/simplecov#449) (thanks @amatsuda) * Do not `mkdir_p` the `coverage_path` on every access of the method (See [#453](simplecov-ruby/simplecov#453) (thanks @paddor) * Fixes a Ruby warning related to the `track_files` configuration. See [#447](simplecov-ruby/simplecov#447) (thanks @craiglittle) * Add a group for background jobs to default Rails profile. See [#442](simplecov-ruby/simplecov#442) (thanks @stve) ## Bugfixes * Fix root_filter evaluates SimpleCov.root before initialization. See [#437](simplecov-ruby/simplecov#437) (thanks @tmtm)
Fixes #462. The implementation of `track_files` was refactored recently to suppress a warning in the underlying instance variable had not been initialized. This had the effect of changing the behavior when trying to nullify the default configuration of tracked files in some cases through the use of nil. With this change, a declaration of `track_files nil` will once again clear out any previous configuration and essentially disable the feature. Reference: * #447 * #462
Fixes #446.