Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to reconnect client into the room #147

Closed
endel opened this issue Apr 29, 2018 · 2 comments
Closed

Allow to reconnect client into the room #147

endel opened this issue Apr 29, 2018 · 2 comments
Milestone

Comments

@endel
Copy link
Member

endel commented Apr 29, 2018

When the WebSocket connection drops unexpectedly, it should be possible to reconnect that client within a certain timespan, even if the room is locked.

Scenarios:

@endel
Copy link
Member Author

endel commented May 14, 2018

Hey @dossy @sandrosc @AnubisCode @ruifly2012,

I'd appreciate if you all could vote on the poll at the pull request #154

Cheers!

@dossy
Copy link

dossy commented May 14, 2018

I voted in favor of on-by-default, although that breaks backwards compatibility in case anyone implemented their own reconnection mechanism in their own codebase, but ultimately for future developers, I think the on-by-default will be the useful behavior.

endel added a commit to colyseus/colyseus.js that referenced this issue May 15, 2018
endel added a commit to colyseus/colyseus-defold that referenced this issue May 15, 2018
endel added a commit to colyseus/colyseus-defold that referenced this issue May 15, 2018
@endel endel closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants