Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https compatibility to Server #38

Closed
msholty-fd opened this issue Feb 25, 2017 · 1 comment
Closed

Add https compatibility to Server #38

msholty-fd opened this issue Feb 25, 2017 · 1 comment

Comments

@msholty-fd
Copy link

As of now, interface ServerOptions asks for an http object. I would like it to accept https as well as http

Is it as easy as changing the interface definition to the following code?

import * from 'https';
export interface ServerOptions {
  server?: http.Server|https.Server;
  port?: number;
  ws?: WebSocketServer;
}

If so I'd be happy to make a PR. If you foresee other issues popping up, let me know and I can also make those changes.

Thanks!

@msholty-fd
Copy link
Author

#39 opened to get this ball rolling

@endel endel closed this as completed in 07a9137 Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant