Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support #39

Closed
wants to merge 1 commit into from
Closed

Add https support #39

wants to merge 1 commit into from

Conversation

msholty-fd
Copy link

I've tested this to allow joins and messages and both seem to work. When connecting, you must use wss instead of ws.

I'd like some direction on ways to document how https is supported, so please let me know what form you'd like this in.

@mention-bot
Copy link

@msholty-fd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @endel, @Greenkeeper and @greenkeeperio-bot to be potential reviewers.

@endel
Copy link
Member

endel commented Feb 25, 2017

Hey @msholty-fd! Thank you so much for your pull-request!

I've made this change differently, though - reusing the IServerOptions from the @types/uws package, which already accepts https.Server as an argument. The https package remains as an optional dependency.

Please let me know if this fits your needs? Thanks!

PS: I've seen you started a pretty cool project using Colyseus, that's awesome :)

@endel endel closed this Feb 25, 2017
@msholty-fd
Copy link
Author

@endel Thanks for the quick response!!

I checked out the most recent version and tested it out. It indeed works for me, without the need for adding a dependency to https. Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants