Disambiguate compiler-interface module name #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's compiled only in Scala 2, and used via dotty compat in Scala 3. For Scala 2, it depends on Scala 2 pprint. For Scala 3, it depends on Scala 3 pprint. Without these changes, only the latter module ends up being published, which makes ammonite for 2.13.6 pull pprint for Scala 3 (along with pprint for Scala 2), which is a problem. Without these changes, the same module (com.lihaoyi:ammonite-compiler-interface_2.13.6) was built and published twice. A few commits ago, these were published in the same batch, so only one (apparently the latter) ended up actually published. Since two commits on master, these are published in separate batches, which makes one of them fail (because it tries to publish a module already published by the other batch).
|
Not sure why I didn't just built compiler-interface with Scala 3, instead of compiling it with Scala 2 and using it from Scala 3 via dotty-compat… Will probably try that in a later PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's compiled only in Scala 2, and used via dotty compat in Scala 3. For Scala 2, it depends on Scala 2 pprint. For Scala 3, it depends on Scala 3 pprint.
Without these changes, only the latter module ends up being published, which makes ammonite for 2.13.6 pull pprint for Scala 3 (along with pprint for Scala 2), which is a problem.
Also, the same module (
com.lihaoyi:ammonite-compiler-interface_2.13.6) was built and published twice. A few commits ago, these were published in the same batch, so only one (apparently the latter) ended up actually published. Since two commits on master, these are published in separate batches, which makes one of them fail (because it tries to publish a module already published by the other batch).With the changes here, we now publish
com.lihaoyi:ammonite-compiler-interface_2.13.6(for Scala 2) andcom.lihaoyi:ammonite-cross-23-compiler-interface_2.13.6(for Scala 3), which solves the ambiguity.Fixes #1214.
Fixes #1197 (hopefully).