Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use_3 for scala-collection-compat #1304

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Oct 18, 2022

scala-collection-compat suffers from the same issue seen in the other deps
In sbt we see:

Modules were resolved with conflicting cross-version suffixes in ProjectRef(uri("file:/..../"), "core"):
[error]    org.scala-lang.modules:scala-collection-compat _3, _2.13

scala-collection-compat suffers from the same issue seen in
the other deps
In sbt we see:

Modules were resolved with conflicting cross-version suffixes in ProjectRef(uri("file:/..../"), "core"):
[error]    org.scala-lang.modules:scala-collection-compat _3, _2.13
@lolgab lolgab marked this pull request as ready for review October 18, 2022 10:33
@lolgab lolgab requested a review from lefou October 18, 2022 10:33
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Should we add some auto-register to the use_3_deps list? Who knows, which dep comes next?

@lolgab lolgab merged commit 626c15b into master Oct 18, 2022
@lolgab lolgab deleted the use-3-scala-collection-compat branch October 18, 2022 13:50
@lolgab
Copy link
Member Author

lolgab commented Oct 18, 2022

Looks good to me.

Should we add some auto-register to the use_3_deps list? Who knows, which dep comes next?

I hope we can migrate to Scala 3 before this becomes a real problem! :)

@lefou lefou added this to the after 2.5.5 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants