Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
case
modifier fromfansi.Str
: we're already overriding apply, equals, hashcode, etc. so being acase class
buys us nothing.Rename
fansi.Str.join
tofansi.Str.apply
, to provide an easy way of concatenating a bunch of string literals e.g.fansi.Str("hello", "world", "i am cow")
Added a new
fansi.Str.join
method that takes aSeq[fansi.Str]
, to make it a bit more ergonomic to join suchSeq
s together. Also include an optionalsep
argument, to handle the use case thatmkString
satisfies onSeq[String]
This is a breaking change, so since we're already breaking compat in a few places in com-lihaoyi we should include this in the update
Review by @lolgab