Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squelch useless warnings on .rep #281

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Squelch useless warnings on .rep #281

merged 4 commits into from
Mar 24, 2023

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Mar 24, 2023

Fixes #279

I added the appropriate @nowarn annotation in the macro.

Tested by enabling -Xfatal-warnings. For now I only do this in Scala 2.13, as Scala 2.11/2.12 have no @nowarn (I had to leave a stub for them) and Scala 3.x (a) doesn't have the same warning and (b) somehow has a bunch of other is more specialized than the right hand side warnings that @nowarn doesn't seem to squelch

@lihaoyi lihaoyi merged commit dac4355 into master Mar 24, 2023
@luigimarano
Copy link

Unfortunately I think this change has been causing problems with my build. I now get the following error message:

@nowarn annotation does not suppress any warnings
scala version 2.13.10

Given that it didn't happen with v3.0.0 I'm just going to stick with that version for now

@gipeshka
Copy link

gipeshka commented Apr 5, 2023

Can confirm that update to 3.0.1 fails with the same message for me.

@SethTisue
Copy link
Contributor

ticket on the "@nowarn annotation does not suppress any warnings" problem is #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about whitespace equality inside rep macro
4 participants