Use CharSequence instead of String for more flexibility #39
Conversation
This e.g. allows using a lazy sequence for streamed parsing. Replaced eager .length calls with less eager charAt calls where needed. Added test that asserts lazyness.
| if (index >= input.length) fail(cfg.failure, index) | ||
| else if (uberSet(input(index))) success(cfg.success, (), index + 1, Nil, false) | ||
| if (Try(input.charAt(index)).isFailure) fail(cfg.failure, index) | ||
| else if (uberSet(input.charAt(index))) success(cfg.success, (), index + 1, Nil, false) |
There was a problem hiding this comment.
@lihaoyi not completely happy with having an intermediate exception being generated here, but .length is too eager. any better ideas?
|
bump :) |
|
Sorry, haven't taken a serious look yet! The |
|
@lihaoyi yeah, maybe we need our own CharSequence :-. Would be good to measure though first what the performace impact of the Try or maybe using try{}catch{} actually is. You have performance tests, right? |
|
Yeah just run https://github.com/lihaoyi/fastparse/blob/master/scalaparse/jvm/src/test/scala/scalaparse/PerfTests.scala and see how long it takes |
|
Closing due to inactivity |
This e.g. allows using a lazy sequence for streamed parsing. Replaced eager .length calls with less eager charAt calls where needed. Added test that asserts laziness.
fixes #18