PublishModule deletes moduleDeps created by other traits

[lolgab]

PublshModule has the following code:

override def moduleDeps: Seq[PublishModule] = Seq.empty[PublishModule]

mill/scalalib/src/PublishModule.scala

Line 16 in c985ef8

override def moduleDeps: Seq[PublishModule] = Seq.empty[PublishModule]

which creates a very strange behaviour when a base trait manipulates the moduleDeps. If you add with PublishModule the dependencies added previously by other traits disappear.

Proposed solution

If it's important that all the moduleDeps are PublishModules, it should instead iterate over the moduleDeps and make sure that all the moduleDeps are proper PublishModules, and then cast the result if the requirement passes, but it shouldn't delete any existing moduleDeps otherwise.

[lefou]

PublshModule has the following code:

override def moduleDeps: Seq[PublishModule] = Seq.empty[PublishModule]

mill/scalalib/src/PublishModule.scala

Line 16 in c985ef8

override def moduleDeps: Seq[PublishModule] = Seq.empty[PublishModule]

which creates a very strange behaviour when a base trait manipulates the moduleDeps. If you add with PublishModule the dependencies added previously by other traits disappear.

Proposed solution

If it's important that all the moduleDeps are PublishModules, it should instead iterate over the moduleDeps and make sure that all the moduleDeps are proper PublishModules, and then cast the result if the requirement passes, but it shouldn't delete any existing moduleDeps otherwise.

I agree. We should call super.moduleDeps and fail with a sensible error message if any of them is not a PublishModule