-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreign modules in T.workspace
are not stored in out/foreign-modules/
#2130
Comments
You find me puzzled. Since when is it possible to declare Mill modules in objects in non- So, after the first shock, back to the point. I think you posted the wrong content for The right solution depends somewhat on whether we stick with Ammonite or go an alternative route, which is based on a new If we want to stick with Ammonite (or just want a fix as soon as possible), we need to encode the name of the include file name. We currently only do this, if its location is different from mill/main/src/mill/main/MainRunner.scala Line 192 in 2a28295
|
I don't. I use other files to put modules that contain generated code or something I don't have to interact with, so the
Since the From a first look the solution would to to check the build file path and use I would love to see in the future a unopinionated approach where users can decide if they want to use Ammonite, scala-cli or a plain Scala build with a meta mill build. The last would be my favourite since it's the least magical, but at the same time I would not like to force any decision to other users that are happy with Ammonite. |
How did I find the bug? |
I agree, we should fix it in the current implementation. |
I'm still a bit undecided, whether this is an issue with Mill or Ammonite. It works, as |
With this change, we always give included files a unique foreign module path. This makes the `dest` path more consistent and robust. Unfortunately, this slightly changes the encoding of foreign modules names. This is no issue when writing `.sc` files, but it will be visible in the progress output and in BSP client and IntelliJ Idea. E.g. the name of an included file in directory `proj1` containing a module `proj1`, will now have the module name "foreign-modules.proj1.build.proj1", whereas previously it was "foreign-modules.proj1.proj1". * Fix #2130 Pull request: #2132
If you have to
.sc
files in the root, the other files modules are not stored inout/foreign-modules
, colliding when the modules have the same name.Example:
The text was updated successfully, but these errors were encountered: