Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixed for Windows #1146

Merged
merged 9 commits into from
Feb 6, 2021
Merged

Various Fixed for Windows #1146

merged 9 commits into from
Feb 6, 2021

Conversation

lefou
Copy link
Member

@lefou lefou commented Feb 5, 2021

Various fixes only shown on Windows, probably also elsewhere.

  • Fixed string stream writer/reader used for mill client-server communication, by using an explicit charset for byte conversion
  • Avoid java.nio.file.Paths.get(url.getFile()) in favour of java.nio.file.Paths.get(url.toURI()) as the latter handles windows paths with leading drive letters well
  • Improved CI setup for Windows
  • Better run/spawn of Java sub-processes by selecting the same Java executable which is used by mill

We still have some CI failures on Windows, as we need some of these fixed in mill before we can benefit from it. Expect more PRs.

Probably related issues:

@lefou lefou changed the title CI: Added test on Windows CI: Various Fixed for Windows Feb 6, 2021
@lefou lefou changed the title CI: Various Fixed for Windows Various Fixed for Windows Feb 6, 2021
@lefou lefou merged commit 84021ec into com-lihaoyi:master Feb 6, 2021
@lefou lefou deleted the ci-win branch February 6, 2021 13:40
@lefou lefou added this to the after 0.9.5 milestone Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant