Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't loose moduleDeps from super traits in PublishModule #2083

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Don't loose moduleDeps from super traits in PublishModule #2083

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41e87bd
Fix #2082 Not delete moduleDeps from super traits in PublishModule
lolgab Oct 24, 2022
01bf606
Avoid NoStackTrace exception
lolgab Oct 24, 2022
fabcaf3
Exclude ReversedMissingMethodProblem for .super call
lolgab Oct 24, 2022
3330806
Run Scalafmt
lolgab Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion scalalib/src/PublishModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,17 @@ import mill.scalalib.publish.{Artifact, VersionScheme, SonatypePublisher}
trait PublishModule extends JavaModule { outer =>
import mill.scalalib.publish._

override def moduleDeps: Seq[PublishModule] = Seq.empty[PublishModule]
private class Error(msg: String) extends scala.util.control.NoStackTrace {
override def getMessage() = msg
}

override def moduleDeps: Seq[PublishModule] = super.moduleDeps.map {
case m: PublishModule => m
case other =>
throw new Error(
s"PublishModule moduleDeps need to be also PublishModules. $other is not a PublishModule"
)
}

def pomSettings: T[PomSettings]
def publishVersion: T[String]
Expand Down