BSP: Improve support for mill-build module and the build.sc
#2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
changed the title
mill-build modulemill-build module and the build.sc
lefou
force-pushed
the
bsp-small-steps
branch
from
4e34bc2
to
cefee93
Compare
lefou
changed the title
mill-build module and the build.scmill-build module and the build.sc
lefou
force-pushed
the
bsp-small-steps
branch
from
cefee93
to
1fb5d43
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the editing experience for
build.scfiles in Metals.We now rudimentary detect ammonite includes (
$fileand$ivy).We somewhat break the BSP protocol now, as we return
sourcesas paths to single files instead of directories. It is known, that IDEA does not handle it well, but Metals seems to have no problem with it. We don't report directories as thebuild.scis located in the project top-level directory, and it would contain all other project files too, which is definitely not what we want.Also I refined the module dependencies:
compileIvyDepsnow returns Mill-provided fixed dependencies,ivyDepsreturns all extra resources included via Ammonite$ivyimports, andscalacPluginIvyDepsnow includes Mill own compiler plugins which among other things make theoverridekeyword optional.I also restructured some source files in
mill.scalalib.bsppackage.Fixed the overridden-check for
compiledClassesAndSemanticDbFiles. This should significantly speed things up for larger projects.