Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalaJSModule: Deprecate fastOpt and fullOpt #2326

Merged
merged 3 commits into from
Mar 30, 2023
Merged

ScalaJSModule: Deprecate fastOpt and fullOpt #2326

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15a24ec
`ScalaJSModule`: Deprecate `fastOpt` and `fullOpt`
lefou Feb 18, 2023
08b72db
Apply suggestions from code review
lefou Mar 30, 2023
fa668d2
Merge branch 'main' into depr-js
lefou Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scalajslib/src/mill/scalajslib/ScalaJSModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,12 @@ trait ScalaJSModule extends scalalib.ScalaModule { outer =>
linkTask(isFullLinkJS = true, forceOutJs = false)()
}

@deprecated("Use fastLinkJS instead", "Mill after 0.10.11")
lefou marked this conversation as resolved.
Show resolved Hide resolved
def fastOpt: Target[PathRef] = T {
getReportMainFilePathRef(linkTask(isFullLinkJS = false, forceOutJs = true)())
}

@deprecated("Use fullLinkJS instead", "Mill after 0.10.11")
lefou marked this conversation as resolved.
Show resolved Hide resolved
def fullOpt: Target[PathRef] = T {
getReportMainFilePathRef(linkTask(isFullLinkJS = true, forceOutJs = true)())
}
Expand Down