Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zio-test to TestModule #2432

Merged
merged 4 commits into from
Apr 15, 2023
Merged

Add zio-test to TestModule #2432

merged 4 commits into from
Apr 15, 2023

Conversation

carlosedp
Copy link
Contributor

This PR adds ZIOTest framework to TestModule.

lefou
lefou reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks.

readme.adoc Outdated Show resolved Hide resolved
@carlosedp
Copy link
Contributor Author

My last commit also added a small example using it.

@carlosedp carlosedp requested a review from lefou April 12, 2023 18:58
lefou
lefou reviewed Apr 13, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer ZioTest instead of ZIOTest, which is more in line with other naming in Mill (except ScalaJS for compatibility reasons), e.g. TestNg vs. TestNG. But I'm open for arguments.

@carlosedp
Copy link
Contributor Author

I agree, this makes trait naming more homogeneous.

@lefou lefou merged commit 18711b6 into com-lihaoyi:main Apr 15, 2023
@lefou lefou added this to the 0.11.0-M8 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0-M8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlosedp @lefou