-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate SelectMode.Single and backport evalOrThrow API #2570
Conversation
This supersedes #2554, I guess? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR breaks binary compatibility.
I guess this is because you can't have the same methods defined as static and non-static. @lolgab Should we revert this? |
But if I look closer, the signature of the class's |
The actual class file seen to contain boths methods, so this is probably a false positive?
|
No description provided.