Fix source links in API documentation #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized this doesn't handle unidocLocal properly, easy fix though, just can't merge yet |
|
Okay, tested |
lefou
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API documentation has links to local files (e.g. mill.define.Args points to
file:///home/runner/work/mill/mill/main/define/src/mill/define/Args.scala). This PR is for fixing that.There's already code to replace every occurrence of
file://path/to/project/rootwith the right URL, but it's for.scalafiles so I didn't touch it. I figured-sourcepathwas a safer way to do the same thing.