Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update external plugin reference that supports 0.11 #2621

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Update external plugin reference that supports 0.11 #2621

merged 3 commits into from
Jun 21, 2023

Conversation

daddykotex
Copy link
Contributor

The older version does not resolve using the mill 0.11 --import flag so the example given is just failing.

@daddykotex
Copy link
Contributor Author

daddykotex commented Jun 20, 2023 •
edited

Screenshot 2023-06-20 at 15 53 05

Sorry for the bad cropping, but it's just a proof that it worked, I generated the docs with mill docs.githubPages, on the left you get the result with the actual version in the html

lefou
lefou reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I added two suggestions, to enable future Scala-Steward updates.

build.sc Outdated Show resolved Hide resolved
build.sc Outdated Show resolved Hide resolved
@daddykotex @lefou
Change artifact for mill scip plugin and use it as a dependency
253f30a 
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
lefou
lefou approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lefou lefou merged commit c53dfbe into com-lihaoyi:main Jun 21, 2023
37 checks passed
@lefou lefou added this to the 0.11.1 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daddykotex @lefou