Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSP: Fix MatchError when matching on modules in BSP #2626

Merged
merged 1 commit into from
Jun 22, 2023
Merged

BSP: Fix MatchError when matching on modules in BSP #2626

merged 1 commit into from
Jun 22, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Jun 22, 2023 •
edited

Fixes #2591

@lolgab lolgab marked this pull request as ready for review June 22, 2023 09:31
@lolgab lolgab requested a review from lefou June 22, 2023 09:31
lefou
lefou approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lolgab lolgab mentioned this pull request Jun 22, 2023
Closed
@lefou lefou merged commit 18a61d4 into com-lihaoyi:main Jun 22, 2023
37 checks passed
@lefou lefou added this to the 0.11.1 milestone Jun 22, 2023
@lefou lefou changed the title Fix #2591: MatchError matching on modules in BSP BSP: Fix MatchError when matching on modules in BSP Jun 22, 2023
@lolgab lolgab deleted the fix-bsp-#2591 branch June 22, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.

Internal error response to buildTarget/scalaTestClasses
2 participants
@lolgab @lefou