Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package of mill.contrib.bloop.Bloop module #2628

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Jun 22, 2023

Fixes #2622

@lolgab lolgab changed the title Restore mill.contrib.bloop.Bloop and deprecate mill.contrib.Bloop again Restore mill.contrib.bloop.Bloop and deprecate mill.contrib.Bloop again Jun 22, 2023
@lolgab lolgab marked this pull request as ready for review June 22, 2023 13:20
@lolgab lolgab requested a review from lefou June 22, 2023 13:20
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed the long deprecated mill.contrib.Bloop in 0.11.0-M1 and only accidentally moved the mill.contrib.bloop.Bloop back to mill.contrib.Bloop in 0.10.0-M10. Therefore I think we shouldn't re-keep the deprecated mill.contrib.Bloop, but just fix the package name to mill.contrib.bloop.

@lolgab lolgab changed the title Restore mill.contrib.bloop.Bloop and deprecate mill.contrib.Bloop again Fix mill.contrib.bloop.Bloop package Jun 22, 2023
@lefou lefou changed the title Fix mill.contrib.bloop.Bloop package Fix package of mill.contrib.bloop.Bloop module Jun 22, 2023
@lefou lefou merged commit 1c308fd into com-lihaoyi:main Jun 22, 2023
35 checks passed
@lefou lefou added this to the 0.11.1 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bloop import doesn't work anymore
2 participants