use bspCompileClassesPath in bspTransitiveCompileClasspath #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is my first contribution, so please let me know if there is anything for me to do.
As far as I understand this is OK, since
bspCompileClasspathmentions it tries not to trigger compilation, so the transitive version may also try not to trigger compilation of the module dependencies.This would be helpful to us, since we currently cannot load projects in intellij via bsp if there is a compilation error in any module other than the topmost module. On the surface this seems similar to the issue in #2484 (failing on
buildTarget/scalacOptionsdue to an error within_.compile).