Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Fix --silent flag #2695

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[RFC] Fix --silent flag #2695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion readme.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,13 +331,14 @@ _Changes since {prev-version}:_
analysis to see which targets depend on the code that was changed. See
https://github.com/com-lihaoyi/mill/pull/2417[#2417] for more details


* Fix redirection of stdout stream to stderr when using `show`
https://github.com/com-lihaoyi/mill/pull/2689[#2689]

* Fix line numbers in errors for scripts starting with leading comments or
whitespace https://github.com/com-lihaoyi/mill/pull/2686[#2686]

* Fix issue with BSP protocol crashing due to use of wrong evaluator
https://github.com/com-lihaoyi/mill/pull/2692[#2692]

_For details refer to
{link-milestone}/{milestone}?closed=1[milestone {milestone-name}]
Expand Down
8 changes: 7 additions & 1 deletion runner/src/mill/runner/MillMain.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,13 @@ object MillMain {
enableTicker = enableTicker.getOrElse(mainInteractive),
infoColor = colors.info,
errorColor = colors.error,
systemStreams = streams,
systemStreams =
if (config.silent.value) new SystemStreams(
new java.io.PrintStream(mill.api.DummyOutputStream),
new java.io.PrintStream(mill.api.DummyOutputStream),
streams.in
)
else streams,
debugEnabled = config.debugLog.value,
context = "",
printLoggerState
Expand Down