Use quick = true when calculating PathRef for Mill executable
#2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Mill executable is a static file that is downloaded and doesn't change. Changing the `PathRef` calculation to `quick = true` makes it invalidate the cache everytime the mill executable changes. Before it took ~160ms, after it takes ~100μs ~100 times faster. This code runs twice on every Mill command line task execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mill executable is a static file that is downloaded and doesn't change. Changing the
PathRefcalculation toquick = truemakes it invalidate the cache everytime the mill executable changes.Before it took ~160ms, after it takes ~100μs ~100 times faster. This code runs twice on every Mill command line task execution.
This also stores the
PathRefs in memory so they don't need to be computed on every command invocationPull request: #2785