Cycle detection in moduleDeps and compileModuleDeps

[lefou]

This is a squashed and rebased version of #2349. It depends on #2789 to properly report and exit Mill with a MillException.

The problem: We currently don't detect cycles in transitive moduleDeps and compileModuleDeps. Cycles in these result in a StackOverflowError.

To solve this, we first need to detect cycles. This is the newly added ModuleUtils.recursive method. Instead of moduleDeps we use the moduleDepsChecked in some places to ensure we checked for cycles before accessing module dependencies.

Unfortunately, we can't easily report the detected cycle at evaluation time, as moduleDeps needs to be evaluated before we can create a task graph (via T.traverse), hence we need an alternative way to propagate the exception. The current approach throws an BuildScriptException which itself derives from the also mill.api.MillException (as part of PR #2789).

In MillMain as well as MillClientMain, our central entry points to Mill, we catch the MillException and report the error to the user.

• Fix Logical loops in moduleDeps #2341

Pull request: #2790