fix: Errors not cleaning up in BSP for Scala 3 #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Scala 3 compiler is not calling `startUnit` as the Scala 2 compiler. I checked what sbt is doing and it sends a build/publishDiagnostics for all the compiled files at the end of compilation. So I'm doing the same here. I removed the `CompileProgress` and I'm calling fileVisited for all input files instead. I tried to not touch the `CompileProblemReporter` trait for now since it's public API and I don't want to deal with the binary compatibility issues. Moreover, our current `fileVisited` API seems more than enough
tgodzik
reviewed
Oct 3, 2023
| @@ -492,28 +492,6 @@ class ZincWorkerImpl( | |||
| .map(path => converter.toVirtualFile(path.toNIO)) | |||
| .toArray | |||
|
|
|||
| // We want to listed to all compiled files | |||
| val compileProgress = reporter.map { reporter => | |||
There was a problem hiding this comment.
The issue is most likely here scala/scala3#13082
Wouldn't CompileProgress be useful for reporting % of the compilation or does mill handle it differently?
There was a problem hiding this comment.
We are not reporting % of the compilation in Mill yet. I'm creating an issue so we don't forget about it.
There was a problem hiding this comment.
Thanks! Anyway, this needs the fix for Scala 3, but otherwise we can probably copy the logic from Bloop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scala 3 compiler is not calling
startUnitas the Scala 2 compiler. I checked what sbt is doing and it sends a build/publishDiagnostics for all the compiled files at the end of compilation. So I'm doing the same here.I removed the
CompileProgressand I'm calling fileVisited for all input files instead.I tried to not touch the
CompileProblemReportertrait for now since it's public API and I don't want to deal with the binary compatibility issues. Moreover, our currentfileVisitedAPI seems more than enough.Fixes #2426
Pull request: #2810