Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use play-pekko-http-server in Play 3 #2862

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Use play-pekko-http-server in Play 3 #2862

merged 3 commits into from
Nov 8, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Nov 7, 2023 •
edited

  • Update Play documentation
  • Deprecate SingleModule trait

Pull Request: #2862

@lolgab
Use play-pekko-http-server in Play 3
bee0592 
Update Play documentation
Deprecate SingleModule trait
lefou
lefou approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I found one typo.

contrib/playlib/readme.adoc Outdated Show resolved Hide resolved
lolgab and others added 2 commits November 7, 2023 15:38
@lolgab
Test that all dependencies exist
2e8c073
@lolgab @lefou
Fix typo in play docs
ceb8763 
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
@lolgab lolgab marked this pull request as ready for review November 7, 2023 14:58
@lolgab lolgab merged commit 4c27216 into com-lihaoyi:main Nov 8, 2023
37 checks passed
@lolgab lolgab deleted the play-fixes branch November 8, 2023 09:19
@lefou lefou added this to the 0.11.6 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lolgab @lefou