Pass scalac plugins to scaladoc #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Geez more compiler interface problems :/ @julianmichael can you try poking/shaking it to see if you can make any progress? I might be able to help dig into it and get it fixed, but probably not anytime soon |
|
I don't think I have the time unfortunately... plus this works as a stopgap solution for me for now (I'm not using JDK 9, which...seems to be the problem?). I will try to come back to this at some point though. |
|
maybe try rebasing on master and kicking off another build? |
Plus a couple tests to sanity check.
|
Otherwise don't worry about it, just leave this here and I'll find time to figure it out |
|
@robby-phd any idea why these tests appear to be sad on java 9? |
|
merged in 3eb6235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282. Passing the flags as @lihaoyi suggested seemed to do the trick (thanks!), and docJar and publishing now seem to be working. I added a small test case with the example from the issue, which fails before the change and succeeds after.