Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSP: Add JavaModule.bspBuildTargetData to make JavaModule reports workable BuildTarget #2930

Merged
merged 3 commits into from Jan 3, 2024

Conversation

chikei
Copy link
Contributor

@chikei chikei commented Dec 22, 2023

it was not reporting BuildTarget.dataKind and data such that IJ will not ask BuildTargetJavacOptions for JavaModule and resolved as no dependency at all.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Thank you!

@lefou
Copy link
Member

lefou commented Dec 22, 2023

I took the opportunity to also reuse the JvmBuildTarget in the ScalaBuildTarget data.

@lefou
Copy link
Member

lefou commented Dec 22, 2023

Looks like you just force-pushed my changes away.

@chikei
Copy link
Contributor Author

chikei commented Dec 22, 2023

my bad, forgot to check github first before push the formatted code :/

@lefou
Copy link
Member

lefou commented Dec 22, 2023

Don't worry. My edit was very shortly after yours, so I was calling for it. ;)

@lefou lefou changed the title add JavaModule.bspBuildTargetData to make JavaModule reports workable BuildTarget BSP: Add JavaModule.bspBuildTargetData to make JavaModule reports workable BuildTarget Jan 3, 2024
@lefou lefou merged commit 7c9c11c into com-lihaoyi:main Jan 3, 2024
38 checks passed
@lefou lefou added this to the 0.11.7 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants