POC: Make BSP modular and support dynamic extensions #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
force-pushed
the
bsp-modular
branch
2 times, most recently
from
5a6ec74
to
6e12d8f
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
BspExtensiontrait, which holds a class name and it's potential ivy dependencies.Split up the various BSP server extensions and instantiate them independently. They are now concrete classes with either a default contructor or one accepting the new
MillBuildServerBaseparameter.The
BspModulenow has a newbspExtensionsmethod, which declares what BSP extension should be used to support the module. The extension is loaded via reflection.JavaModuleandScalaModulenow explicitly declare their extensions. That means, if noScalaModuleis part of the project, we also should not load the extension.