Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSP: Send logMessage instead of diagnostics when textDocument is unknown #2979

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

lefou
Copy link
Member

@lefou lefou commented Jan 18, 2024

Since some compiler messages do not belong to a single source file, they are not actionable (in the sense of a BSP build/publishDiagnostics). In such situation (no text document), we send build/logMessage instead.

Fix #2926

@lefou lefou requested review from lolgab and ckipp01 January 18, 2024 12:33
Copy link
Collaborator

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes sense 👍🏼

@lefou lefou merged commit 2821d6f into main Jan 18, 2024
38 checks passed
@lefou lefou deleted the bsp-fix-diagnostics branch January 18, 2024 21:13
@lefou lefou added this to the 0.11.7 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BSP: Invalid textDocument field in build/publishDiagnostics notification
2 participants