Pass long Mill props via file #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
requested changes
Jan 31, 2020
Merged
|
Superseded by #791 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing Mill on Windows, there is an unavoidable issue of command line limit of about 8000 characters.
The only way to bypass it is to have less parameters. This change writes all of Mill's
LongPropsto amill.propertiesfile. Then it passes that file path as system property calledMILL_OPTIONS_PATH...IMHO, it's not ok to build different launchers on different OS-es, e.g.
launcher + prependShellScriptbuilds one artifact on Linux and different on Windows..I think we should build an executable JAR with just one entry point. And have scripts for Bash and Batch, just like Gradle does... That would simplify things a lot I think.