Fix sources in source maps

[artursoler]

When using source maps with scalatags, it produces sources which are local to the computer where it has been compiled.

I first opened an issue in scala-js, thinking it was a compiler's issue. The available fix is explained in there: scala-js/scala-js#993

[japgolly]

@lihaoyi This project doesn't have any Git tags (which I was going to use in the source map URL). Are you not tagging or have you just not pushed the tags via git push --tags?

[lihaoyi]

I haven't been tagging my git versions =< I've been lazy and just leaving the versions as commit messages. I assume you want git tags because you can get construct a URL on github which points to a particular tag?

[japgolly]

Bingo. I closed a similar request for scalajs-react with japgolly/scalajs-react@1541a16 and was going to do the same here, then realised no tags.

[lihaoyi]

Hmm ok, I guess I could publish a new version properly tagged and redirect the source maps at the same time

[japgolly]

I find that way to be the easiest. Added bonus is that Github will recognise the tags as releases whereas for scalatags github currently says "0 releases". Git also allows you to apply tags retrospectively so you can still tag those past releases if you so wish.

[japgolly]

Here's slightly different method. Just added this for Scalaz.js.
japgolly/scalaz@57be87d

[japgolly]

Dude, I just upgrade Chrome (to 38.0.2125.101) and it seems they've added source map validation. Just loading a page now gets my JS console spammed with:

Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/scalatags/js/../shared/main/scala/scalatags/generic/Util.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/scalatags/js/../shared/main/scala/scalatags/generic/Bundle.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/scalatags/js/../shared/main/scala/scalatags/generic/Attrs.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/scalatags/js/../shared/main/scala/scalatags/generic/Styles.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/scalatags/js/../shared/main/scala/scalatags/generic/Core.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/upickle/js/target/scala-2.11/src_managed/main/upickle/Generated.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/upickle/js/shared/main/scala/upickle/package.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/upickle/js/shared/main/scala/upickle/Types.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/upickle/js/shared/main/scala/upickle/GeneratedUtil.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/upickle/js/shared/main/scala/upickle/Js.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/upickle/js/shared/main/scala/upickle/Implicits.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/scalatags/js/../shared/main/scala/scalatags/Escaping.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map
Failed to locate workspace file mapped to URL file:///Users/haoyi/Dropbox%20(Personal)/Workspace/upickle/js/src/main/scala/upickle/json/package.scala from source map http://localhost:8080/assets/dev/webapp-client-fastopt.js.map

[lihaoyi]

oops =/ Is this the kind of thing you can create a PR for? I've been busy with work and haven't had time to come back to this

[lihaoyi]

If you want-to/can send a PR with a fix, I'll happily take it ^_^

[japgolly]

Yeah, no worries. For the PR to effective though, you'll need to start tagging and pushing the tags.

[japgolly]

Btw I just followed what seemed to be the norm for the tagging format, which is "v" + <version>. So 0.4.0 will expect a tag called v0.4.0

[lihaoyi]

I just published 0.4.2 which should be published with the corrected source maps, but is otherwise identical to 0.4.1. Try it out and feel free to reopen if it doesn't work =)

[japgolly]

Will do. Thanks!

On 10 October 2014 14:40, Li Haoyi notifications@github.com wrote:

I just published 0.4.2 which should be published with the corrected source
maps, but is otherwise identical to 0.4.1. Try it out and feel free to
reopen if it doesn't work =)

—
Reply to this email directly or view it on GitHub
#37 (comment).

[japgolly]

@lihaoyi It appears you forgot to push the v0.4.2 tag :)

[japgolly]

Just tested this and can confirm: The source maps are pointing to github instead of spamming console. Great. Just need to push that tag and we're done.

[lihaoyi]

Oops, I think I just pushed the tag, try again?

[japgolly]

Bad news, it seems that GitHub doesn't follow symlinks so everything under js/shared doesn't work.

The source map tries to access:
https://raw.githubusercontent.com/lihaoyi/scalatags/v0.4.2/js/shared/main/scala/scalatags/generic/Attrs.scala

As sourcemaps are only needed for JS, a hacky workaround would be to make js/shared the real dir, and point shared to it instead. Flip the source & target. Just an idea. Up to you :)

[lihaoyi]

@japgolly I tried the "/js/shared is the real thing, /jvm/shared is symlink, remove /shared" thing and updated the v0.4.2 tag to point at the latest commit. Want to try again?

[japgolly]

That's fixed it. Works perfectly now. Thanks Haoyi!~