Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-op PR to trigger CI #807

Closed
wants to merge 1 commit into from
Closed

Conversation

alexholmes
Copy link
Contributor

@alexholmes alexholmes commented Mar 31, 2022

My other PR #806 is failing in the Python 3.7 build and I'm unable to reproduce the failure locally, just creating a clean PR to verify that the CI build is good.

@ancasarb
Copy link
Member

ancasarb commented Apr 1, 2022

hey @alexholmes it seems the error is caused by this

Traceback (most recent call last):
  File "setup.py", line 22, in <module>
    from setuptools import setup, find_packages
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/__init__.py", line 18, in <module>
    from setuptools.dist import Distribution
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/dist.py", line 34, in <module>
    from ._importlib import metadata
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/_importlib.py", line 28, in <module>
    disable_importlib_metadata_finder(metadata)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/_importlib.py", line 12, in disable_importlib_metadata_finder
    import importlib_metadata
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 471, in <module>
    __version__ = version(__name__)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 438, in version
    return distribution(package).version
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 411, in distribution
    return Distribution.from_name(package)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 179, in from_name
    dists = resolver(name)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/_vendor/importlib_metadata/__init__.py", line 886, in find_distributions
    found = self._search_paths(context.name, context.path)
AttributeError: 'str' object has no attribute 'name'

I've created #808 in an attempt to fix the build, i'm not too sure if it's the right way to solve it, so i'll wait for @jsleight to review. sorry for this, will take a look at #806 as soon as the build is green

@alexholmes
Copy link
Contributor Author

Thanks so much @ancasarb - your fix seems to have done the trick!

@jsleight
Copy link
Contributor

jsleight commented Apr 1, 2022

I shipped and merged Anca's branch, so let's close this PR and then you can rebase on master in #806

@jsleight jsleight closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants