Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC-106: remove stateful methods from data companion gRPC API #2230

Closed
mzabaluev opened this issue Feb 2, 2024 · 0 comments · Fixed by #2240
Closed

Implement RFC-106: remove stateful methods from data companion gRPC API #2230

mzabaluev opened this issue Feb 2, 2024 · 0 comments · Fixed by #2240
Assignees
Labels
enhancement New feature or request grpc Anything relating to the gRPC API
Milestone

Comments

@mzabaluev
Copy link
Contributor

We need to implement the API changes discussed in RFC 106 before releasing V1.

@mzabaluev mzabaluev added enhancement New feature or request grpc Anything relating to the gRPC API labels Feb 2, 2024
@mzabaluev mzabaluev self-assigned this Feb 2, 2024
@jmalicevic jmalicevic added this to the 2024-Q1 milestone Feb 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 6, 2024
…ata companion API (#2240)

Resolves #2230

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
mergify bot pushed a commit that referenced this issue Feb 6, 2024
…ata companion API (#2240)

Resolves #2230

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

(cherry picked from commit 27dfc2a)

# Conflicts:
#	rpc/grpc/client/block_results_service.go
#	rpc/grpc/client/block_service.go
#	test/e2e/tests/grpc_test.go
mzabaluev added a commit that referenced this issue Feb 6, 2024
Resolves #2230

(cherry picked from commit 27dfc2a)
melekes pushed a commit that referenced this issue Feb 8, 2024
…ata companion API (#2240)

Resolves #2230

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request grpc Anything relating to the gRPC API
Projects
Status: Done
2 participants