Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABCI: Crash in all cases of undefined app behavior #490

Closed
Tracked by #10
sergio-mena opened this issue Mar 9, 2023 · 0 comments · Fixed by #496
Closed
Tracked by #10

ABCI: Crash in all cases of undefined app behavior #490

sergio-mena opened this issue Mar 9, 2023 · 0 comments · Fixed by #496
Assignees
@sergio-mena
Labels
abci Application blockchain interface

Comments

@sergio-mena
Copy link
Contributor

sergio-mena commented Mar 9, 2023 •
edited
Loading

Was tendermint/tendermint#8206

During the spec/implementation of ABCI 2.0 in v0.36.x, it was decided in tendermint/tendermint#8124 that CometBFT should crash if it received an error from the application from one of the ABCI methods.

This behavior was decided as correct since an application responding with invalid data or that has become unresponsive is no longer in a consistent state. Additionally, the Tendermint algorithm can no longer make progress safely.

We should update the rest of the consensus code to crash when ABCI responds with an error or produces invalid data.
@sergio-mena sergio-mena added bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team. abci Application blockchain interface and removed bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team. labels Mar 9, 2023
@sergio-mena sergio-mena self-assigned this Mar 9, 2023
This was referenced Mar 9, 2023
Closed
Merged
@sergio-mena sergio-mena mentioned this issue Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergio-mena sergio-mena

Labels
abci Application blockchain interface
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ABCI calls should crash/exit in all cases when the call itself reports and error cometbft/cometbft
1 participant
@sergio-mena