Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in all cases of undefined app behavior #8206

Closed
Tracked by #9916
williambanfield opened this issue Mar 28, 2022 · 0 comments
Closed
Tracked by #9916

Crash in all cases of undefined app behavior #8206

williambanfield opened this issue Mar 28, 2022 · 0 comments
Labels
C:abci Component: Application Blockchain Interface stale for use by stalebot

Comments

@williambanfield
Copy link
Contributor

williambanfield commented Mar 28, 2022

During the implementation of ABCI++, it was decided that Tendermint should crash if it received an error from the application from one of the ABCI methods.

This behavior was decided as correct since an application responding with invalid data or that has become unresponsive is no longer in a consistent state. Additionally, the Tendermint algorithm can no safely longer make progress.

We should update the rest of the consensus code to crash when ABCI responds with an error or produces invalid data.

@sergio-mena sergio-mena added this to To do in ABCI++ via automation Mar 29, 2022
@sergio-mena sergio-mena added the C:abci Component: Application Blockchain Interface label Dec 15, 2022
@sergio-mena sergio-mena removed this from To do in ABCI++ Dec 21, 2022
@github-actions github-actions bot added the stale for use by stalebot label May 5, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:abci Component: Application Blockchain Interface stale for use by stalebot
Projects
Status: Done/Merged
Development

No branches or pull requests

2 participants