ABCI 2.0: Final adjustments

[sergio-mena]

Tasks:

• Double-check whether we need something from (tm)#7768 #8
• ABCI 2.0: Protobuf results should be enums #90
  • see what is missing from ABCI++: Update new protos to use enum instead of bool tendermint/tendermint#8158
• Block data exposed to App: follow #8216 and take the parts still missing (mainly FinalizeBlock) #97
• Double-check if there is something we need from abci++: Remove intermediate protos tendermint/tendermint#8414 (probably not)
• Backport vote extension metrics #471 (backport leftovers to v0.37.x Backport resetting of vote metrics upon new round #479)
  • see what metrics we are still missing from consensus: add additional metrics for abci++ data tendermint/tendermint#8480 (mainly vote extensions)
• Redundant params in FinalizeBlock, and obsolete methods (BeginBlock, etc). Double check that changes in Removed redundant params in FinalizeBlock tendermint/tendermint#8598 and/or Remove obsolete abci methods, no longer called by ABCI++ Tendermint tendermint/tendermint#8633 are unnecessary
• Move apphash from Committo FinalizeBlock (leftovers) #478
  • move app_hash from Commit to FinalizeBlock: follow abci: Move app_hash parameter from Commit to FinalizeBlock tendermint/tendermint#8664
• Compare types.proto and feature/abci++vef and tip of v0.36.x #488
• ABCI: Crash in all cases of undefined app behavior #490
• A proposer needs to forward vote extension information to be verified in ProcessProposal #485
• Leftovers
  • ABCI 2.0: Double-check that PreparaProposal and ProcessProposal respect coherence all over our code #514
  • Add sleep times (VoteExtension and Finalizeblock) to e2e app #515
• Bugfixes
  • Fix bugs: (1) infinite loop in e2e tests (2) missing Vote Extensions at PrepareProposal time #539
  • Fix bugs: (1) another infinite loop in e2e tests (2) missing validator info from genesis #542
  • Strengthen CometBFT's internal checks on vote extension enablement #546
  • Fixed two bugs related to metrics #562
• Run a testnet on DO (200 node test) as smoke test on this branch #547
• Once we are code complete, and all CI tests pass, merge branch back into main
  • Merge main into feature/abci++vef (preparation merge) #568
  • Final merge of feature/abci++vef into main #572
• vote.Height < 0 in ValidateBasic method of Vote #510
• Second part of Deprecate blocksync-related configuration in v0.37.x that disables blocksync. Remove it from v0.38.x #409 (remove config to disable blocksync)

DoD:

• No errors in CI
• No major concerns if testnets were run
• Branch feature/abci++vef has been merged back into main

Original issue: tendermint/tendermint#9916

[sergio-mena]

Closing as all tasks have been completed