Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool/p2p: Research implications of peer disconnect based on ResponseCheckTx #66

Closed
Tracked by #65 ...
jmalicevic opened this issue Dec 27, 2022 · 0 comments · Fixed by #78
Closed
Tracked by #65 ...

mempool/p2p: Research implications of peer disconnect based on ResponseCheckTx #66

jmalicevic opened this issue Dec 27, 2022 · 0 comments · Fixed by #78
Assignees

Comments

@jmalicevic
Copy link
Contributor

jmalicevic commented Dec 27, 2022

Original issue: tendermint/tendermint#9546

As mentioned in tendermint/tendermint#7918 and tendermint/tendermint#2185, it might be of interest to disconnect from a peer when receiving transactions that could never have been valid.

Before implementing this behaviour we want to look into more details of such a behaviour. Namely:

  • The use case where a node sends transactions that could never have been valid;
  • Implications on the security and correctness model of Tendermint (how does the application know that it is this particular peer that should be removed, is this scenario not covered already by other layers in Tendermint, etc.);
  • What other changes in other parts of Tendermint should the implementation of this require;
  • If solution/problem still seem valuable, propose an implementation path taking into account potential need to refactor and change the p2p layer itself to support this.
@jmalicevic jmalicevic self-assigned this Dec 27, 2022
cometcrafter pushed a commit to graphprotocol/cometbft that referenced this issue Jun 1, 2024
…Meta (backport cometbft#2964) (cometbft#2998) (cometbft#62) (cometbft#66)

* perf(consensus/blockstore): Remove validate basic call from LoadBlockMeta (cometbft#2998) (cometbft#62)

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
(cherry picked from commit c73455f)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant