Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON serialization of ExecTxResult breaks naming of fields as they were in ResponseDeliverTx #855

Closed
mzabaluev opened this issue May 17, 2023 · 0 comments · Fixed by #856
Closed

JSON serialization of ExecTxResult breaks naming of fields as they were in ResponseDeliverTx #855

mzabaluev opened this issue May 17, 2023 · 0 comments · Fixed by #856
Labels
bug Something isn't working rpc

Comments

@mzabaluev
Copy link
Contributor

tendermint/tendermint#9468 introduced the ExecTxResult message type as a drop-in replacement for ResponseDeliverTx where it was used inside other messages. However, it did not carry over the options that explicitly set names for some of the fields:

  int64          gas_wanted = 5 [json_name = "gas_wanted"];
  int64          gas_used   = 6 [json_name = "gas_used"];

As a result, the JSON serialization of the structures containing ExecTxResult in RPC has changed in a backward-incompatible way.
@mzabaluev mzabaluev added bug Something isn't working rpc labels May 17, 2023
@mzabaluev mzabaluev mentioned this issue May 17, 2023
Merged
3 tasks
@mergify mergify bot closed this as completed in #856 May 19, 2023
mergify bot pushed a commit that referenced this issue May 19, 2023
@mzabaluev
proto: Restore snake_case JSON for ExecTxResult (#856)
40e6611 
Fixes: #855

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
mergify bot pushed a commit that referenced this issue May 19, 2023
@mzabaluev @mergify
proto: Restore snake_case JSON for ExecTxResult (#856)
8e24c77 
Fixes: #855

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments

(cherry picked from commit 40e6611)
mzabaluev pushed a commit that referenced this issue May 19, 2023
@mergify
proto: Restore snake_case JSON for ExecTxResult (backport #856) (#862)
0511efa 
* proto: Restore snake_case JSON for `ExecTxResult` (#856)

Fixes: #855
BrendanChou pushed a commit to BrendanChou/cometbft that referenced this issue May 23, 2023
@mzabaluev @BrendanChou
proto: Restore snake_case JSON for ExecTxResult (cometbft#856)
af6c920 
Fixes: cometbft#855

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proto: Restore snake_case JSON for ExecTxResult cometbft/cometbft
1 participant
@mzabaluev