0.34.x: Rename Tendermint to CometBFT: further actions (backport #224) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* rename: Tendermint -> CometBFT in README files * rename: Tendermint -> CometBFT in doc.go files * rename: Tendermint -> CometBFT in Go documentation * Removing unused/outdated CHANGELOGs * rename: using CometBFT in issues and PR templates * rename: references to tendermin in libs/events * rename: renaming on text files under rpc/ dir * rename: Tendermint-go -> CometBFT in proto docs * rename: Tendermint -> CometBFT in generated go docs * rename: renaming Tendermint -> CometBFT in scripts * rename: renaming to CometBFT in code comments * rename: general script files on repository root * rename: using CometBFT in github config files * rename: Go docs in .proto files, pb.go regenerated * rename: toml config file generated content * rename: avoiding unnecessary TM entries in comments * rename: renaming in log messages and strings * rename: upgrading instructions renamed, needs review * rename: fixing generated protobuf files * rename: fixing generated protobuf files * rename: fixing broken test, renamed string * Apply suggestions from code review * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Thane Thomson <connect@thanethomson.com> * Update abci/README.md Co-authored-by: Thane Thomson <connect@thanethomson.com> * Update proto/README.md Co-authored-by: Thane Thomson <connect@thanethomson.com> * rename: removing unused files on repo root --------- Co-authored-by: Daniel Cason <cason@gandria> Co-authored-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 1cb55d4) # Conflicts: # .github/ISSUE_TEMPLATE/bug-report.md # .github/ISSUE_TEMPLATE/config.yml # .github/PULL_REQUEST_TEMPLATE.md # .github/issue_template.md # .github/workflows/janitor.yml # .github/workflows/lint.yml # .gitignore # .goreleaser.yml # UPGRADING.md # abci/README.md # abci/types/application.go # abci/types/mocks/base.go # cmd/cometbft/commands/version.go # config/config.go # config/toml.go # consensus/README.md # consensus/replay.go # consensus/replay_test.go # consensus/state.go # crypto/README.md # crypto/ed25519/ed25519.go # inspect/doc.go # inspect/inspect.go # internal/test/doc.go # libs/pubsub/query/query.go # libs/pubsub/query/syntax/doc.go # light/doc.go # networks/local/README.md # node/node.go # node/setup.go # p2p/README.md # proto/README.md # rpc/core/abci.go # rpc/core/blocks.go # rpc/core/consensus.go # rpc/core/doc.go # rpc/core/events.go # rpc/core/evidence.go # rpc/core/health.go # rpc/core/mempool.go # rpc/core/net.go # rpc/core/status.go # rpc/core/tx.go # rpc/jsonrpc/doc.go # rpc/openapi/openapi.yaml # scripts/metricsgen/metricsgen.go # test/fuzz/README.md # test/fuzz/oss-fuzz-build.sh # test/loadtime/cmd/load/main.go # tools/README.md # version/version.go
cason
changed the title
cason
reviewed
Feb 6, 2023
cason
reviewed
Feb 6, 2023
cason
reviewed
Feb 6, 2023
cason
reviewed
Feb 6, 2023
Co-authored-by: Jasmina Malicevic <jasmina@informal.systems>
Co-authored-by: Jasmina Malicevic <jasmina@informal.systems>
cason
reviewed
Feb 6, 2023
cason
reviewed
Feb 6, 2023
cason
reviewed
Feb 6, 2023
rpc/core/blocks.go
Outdated
| @@ -169,6 +176,8 @@ func BlockSearchMatchEvents( | |||
| ) (*ctypes.ResultBlockSearch, error) { | |||
| if matchEvents { | |||
| query = "match.events = 1 AND " + query | |||
| } else { | |||
There was a problem hiding this comment.
This was removed in the cherry-pick, re-adding.
cason
reviewed
Feb 6, 2023
rpc/core/tx.go
Outdated
| @@ -149,6 +149,8 @@ func TxSearchMatchEvents( | |||
|
|
|||
| if matchEvents { | |||
| query = "match.events = 1 AND " + query | |||
| } else { | |||
There was a problem hiding this comment.
Removed during the process, re-added.
cason
previously approved these changes
Feb 6, 2023
jmalicevic
reviewed
Feb 6, 2023
jmalicevic
reviewed
Feb 6, 2023
jmalicevic
reviewed
Feb 6, 2023
Codecov ReportBase: 48.45% // Head: 48.39% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## v0.34.x #255 +/- ##
===========================================
- Coverage 48.45% 48.39% -0.06%
===========================================
Files 280 280
Lines 49887 49887
===========================================
- Hits 24172 24144 -28
- Misses 23856 23882 +26
- Partials 1859 1861 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cason
reviewed
Feb 6, 2023
|
Issue #280 should cover more complex renaming in this branch. |
jmalicevic
reviewed
Feb 6, 2023
| @@ -1970,7 +1970,7 @@ type ResponseCheckTx struct { | |||
| Codespace string `protobuf:"bytes,8,opt,name=codespace,proto3" json:"codespace,omitempty"` | |||
| Sender string `protobuf:"bytes,9,opt,name=sender,proto3" json:"sender,omitempty"` | |||
| Priority int64 `protobuf:"varint,10,opt,name=priority,proto3" json:"priority,omitempty"` | |||
| // mempool_error is set by Tendermint. | |||
| // mempool_error is set by CometBFT. | |||
There was a problem hiding this comment.
This was autogenerated right, the PR is not manually changing this?
There was a problem hiding this comment.
Yep, generated using make something.
jmalicevic
reviewed
Feb 6, 2023
jmalicevic
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #224 done by Mergify.
Cherry-pick of 1cb55d4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com