Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): Add clock skew only to processes that accumulate less than 1/3 of voting power #2597

Merged
merged 1 commit into from Mar 13, 2024

Conversation

hvanz
Copy link
Member

@hvanz hvanz commented Mar 12, 2024

Some nightly tests are failing because validators with clock skew and high stake are slowing down progress.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

@hvanz hvanz added bug Something isn't working e2e Related to our end-to-end tests labels Mar 12, 2024
@hvanz hvanz requested review from a team as code owners March 12, 2024 20:55
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hvanz hvanz added the backport-to-v1.x Tell Mergify to backport the PR to v1.x label Mar 13, 2024
@hvanz hvanz added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit f4e5958 Mar 13, 2024
21 checks passed
@hvanz hvanz deleted the hvanz/fix-e2e-generate branch March 13, 2024 07:32
mergify bot pushed a commit that referenced this pull request Mar 13, 2024
…1/3 of voting power (#2597)

Some nightly tests are failing because validators with clock skew and
high stake are slowing down progress.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

(cherry picked from commit f4e5958)
hvanz added a commit that referenced this pull request Mar 13, 2024
…1/3 of voting power (backport #2597) (#2599)

This is an automatic backport of pull request #2597 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v1.x Tell Mergify to backport the PR to v1.x bug Something isn't working e2e Related to our end-to-end tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants