fix(e2e): Increase timeout when waiting for new block #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanz
added
e2e
lasarojc
approved these changes
Mar 13, 2024
|
Is there a timeout on the whole test that could expire before 30 seconds? If we see that the tests still timeouts after this fix, we can fix it in another PR. |
mergify bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
Some nightly test scenarios are failing because the test that checks that new blocks are being created timeouts. This happens on larger networks with many perturbations, on a few heights. Currently the timeout is 5 seconds, but in some cases it takes the network more than 20 seconds to create a block, so this PR changes it to 30 seconds. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 540231c)
4 tasks
|
Cool. The CI relies on Probably enough |
hvanz
added a commit
that referenced
this pull request
Mar 13, 2024
#2609) Some nightly test scenarios are failing because the test that checks that new blocks are being created timeouts. This happens on larger networks with many perturbations, on a few heights. Currently the timeout is 5 seconds, but in some cases it takes the network more than 20 seconds to create a block, so this PR changes it to 30 seconds. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2606 done by [Mergify](https://mergify.com). Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nightly test scenarios are failing because the test that checks that new blocks are being created timeouts. This happens on larger networks with many perturbations, on a few heights. Currently the timeout is 5 seconds, but in some cases it takes the network more than 20 seconds to create a block, so this PR changes it to 30 seconds.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments