Fix bugs: (1) another infinite loop in e2e tests (2) missing validator info from genesis #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #10
This PR contains the fix for two more bugs, one found in the implementation of vote extensions on our e2e app (testing code, not production), the other in the control routines of our e2e tests.
In order to share the troubleshooting process I followed (which someone might find useful), I will follow a similar approach to #539. I will push the commits, one by one, that roughly recreate the steps I followed to root-cause and fix the bugs. I also show I was first able to reproduce it, and then that the fix made the problem disappear. If you're interested, please check out the e2e test results of any steps (i.e., any commit pushed) by clicking on the little ❌ or ✅ next to the relevant commit.
ci.toml
so that there are no updates at height 0 (representing the validator updates the app provides inResponseInitChain
) and that vote extensions are enabled before any other validator updates. Therefore, the app is obliged to use the genesis info it doesn't have (i.e. THE BUG) to verify vote extension signatures.RequestPrepareProposal
#489 which gathers validator data to also apply it with the info coming directly from genesis. There is a ❌ next to the corresponding commit hash, but it is due to the Golang linter failing; the e2e tests are passing for this commit.PR checklist
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code comments