Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs: (1) another infinite loop in e2e tests (2) missing validator info from genesis #542

Merged
merged 6 commits into from
Mar 17, 2023

Conversation

sergio-mena
Copy link
Contributor

@sergio-mena sergio-mena commented Mar 16, 2023

Contributes to #10

This PR contains the fix for two more bugs, one found in the implementation of vote extensions on our e2e app (testing code, not production), the other in the control routines of our e2e tests.

In order to share the troubleshooting process I followed (which someone might find useful), I will follow a similar approach to #539. I will push the commits, one by one, that roughly recreate the steps I followed to root-cause and fix the bugs. I also show I was first able to reproduce it, and then that the fix made the problem disappear. If you're interested, please check out the e2e test results of any steps (i.e., any commit pushed) by clicking on the little ❌ or ✅ next to the relevant commit.

  • Commit#1: Fix infinite loop in e2e routines. We need this first so that, when we repro the other problem, the e2e tests fail (showing the logs, etc) rather than being cancelled by GitHub.
  • Commit#2: Modify file ci.toml so that there are no updates at height 0 (representing the validator updates the app provides in ResponseInitChain) and that vote extensions are enabled before any other validator updates. Therefore, the app is obliged to use the genesis info it doesn't have (i.e. THE BUG) to verify vote extension signatures.
  • Commit#3: the fix. We extend the functionality we introduced in Pass signatures of vote extensions in RequestPrepareProposal #489 which gathers validator data to also apply it with the info coming directly from genesis. There is a ❌ next to the corresponding commit hash, but it is due to the Golang linter failing; the e2e tests are passing for this commit.
  • Commit#4: Fix golang lint.
  • Commit#5: Revert commit#2, with the modifications done to expose the bug.

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@sergio-mena sergio-mena added the abci Application blockchain interface label Mar 16, 2023
@sergio-mena sergio-mena self-assigned this Mar 16, 2023
@sergio-mena sergio-mena requested a review from a team as a code owner March 16, 2023 21:15
@sergio-mena sergio-mena mentioned this pull request Mar 16, 2023
16 tasks
@sergio-mena sergio-mena merged commit 2071c6c into feature/abci++vef Mar 17, 2023
@sergio-mena sergio-mena deleted the sergio/10-fix-missing-validators branch March 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abci Application blockchain interface
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants