Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Replace Gatsby's FileParser by own regexp parser #59

Closed
wants to merge 1 commit into from
Closed

WIP: Replace Gatsby's FileParser by own regexp parser #59

wants to merge 1 commit into from

Conversation

cometkim
Copy link
Owner

See #54

@cometkim cometkim self-assigned this Mar 12, 2020
@lgtm-com
Copy link

lgtm-com bot commented Mar 12, 2020

This pull request introduces 3 alerts when merging 965c456 into bb3f323 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@cometkim
Copy link
Owner Author

I found more use cases that can no longer be handled effectively with RegExp. (eg. fragments)

I have to move on to a babel based parser, but I'm still not sure whether to manage the parser myself or use graphql-tag-pluck.

@cometkim cometkim closed this Apr 12, 2020
@cometkim cometkim deleted the replace-file-parser branch April 12, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cometkim cometkim

Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cometkim